| To: | markb@xxxxxxxxxxxxxx (Mark Broadbent) |
|---|---|
| Subject: | Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Fri, 29 Apr 2005 07:26:41 +1000 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <E1DRFqC-00028H-Qi@tigger> |
| Organization: | Core |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686)) |
Mark Broadbent <markb@xxxxxxxxxxxxxx> wrote: > The interrupt handling code in the tulip network driver appears to use a non > IRQ safe spinlock in an interrupt context. The following patch should > correct > this. This is bogus. Interrupts are already disabled when you're in the interrupt handler. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] optimize check in port-allocation code, folkert |
|---|---|
| Next by Date: | Re: [PATCH] Add more explanation to tcp_prequeue comment, Arnaldo Carvalho de Melo |
| Previous by Thread: | [PATCH] Tulip interrupt uses non IRQ safe spinlock, Mark Broadbent |
| Next by Thread: | Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |