Re: Fw: unregister_netdevice(): negative refcnt, suggest patch against 2.6.11

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Thomas Graf <tgraf@xxxxxxx> wrote:
> 
> OK, I think the problem is a few missing dev_hold() when the net_device
> handle is assigned to routes, probes, etc.

Indeed.  Here is a patch that adds the references that are held by
the routes.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
===== net/appletalk/ddp.c 1.58 vs edited =====
--- 1.58/net/appletalk/ddp.c    2005-03-27 09:04:35 +10:00
+++ edited/net/appletalk/ddp.c  2005-04-18 11:29:17 +10:00
@@ -573,6 +573,7 @@
 
        /* Fill in the routing entry */
        rt->target  = ta->sat_addr;
+       dev_hold(devhint);
        rt->dev     = devhint;
        rt->flags   = r->rt_flags;
        rt->gateway = ga->sat_addr;