Re: Fwd: atomic_dec_and_test for child dst needed in dst_destroy?

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

pravin b shelar <pravins@xxxxxxxxxxxxxx> wrote:
>
> This patch  will remove the need for atomic_dec_and_test for this 
> particular case.
> Now we can break down the atomic_dec_and_test to atomic_dec & atomic_read.

Sorry I overlooked your patch.  Otherwise we could have solved this
one day earlier :)

> Please comment.

There is just one problem.  We need an extra barrier before or after
the goto since we no longer have the implicit barrier given by
atomic_dec_and_test.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt