netdev
[Top] [All Lists]

Re: [PATCH 2.6]: keep fragment queues private to each user

To: kaber@xxxxxxxxx (Patrick McHardy)
Subject: Re: [PATCH 2.6]: keep fragment queues private to each user
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 25 Jan 2005 22:57:03 +1100
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <41F5D1CB.9050804@trash.net>
Organization: Core
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
Patrick McHardy <kaber@xxxxxxxxx> wrote:
> 
> This patch keeps fragment queues private to each ip_defrag user to avoid
> skbs jumping between different callers. It shouldn't change any wanted
> behaviour, the only questionable one was ip_call_ra_chain, but the RA
> option is included in each fragment. If you're fine with the patch I'm going
> to send a 2.4 version later.

Patch looks good.

However, I think this is still not enough.  What about fragments
that come from different interfaces? Fragments with different
security paths?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>