netdev
[Top] [All Lists]

Re: BUG: dst underflow (again)

To: davem@xxxxxxxxxxxxx (David S. Miller)
Subject: Re: BUG: dst underflow (again)
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 06 Nov 2004 12:53:04 +1100
Cc: buytenh@xxxxxxxxxxxxxx, acme@xxxxxxxxxxxxxxxx, hadi@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041105162319.6e2917c5.davem@davemloft.net>
Organization: Core
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
David S. Miller <davem@xxxxxxxxxxxxx> wrote:
> 
> Well, xfrm_lookup() is returning an error somehow, that's the only
> way to execute dst_release() in udpv6_sendmsg().  And xfrm_lookup()

Actually, there are other calls to dst_release in udpv6_sendmsg.  For
example, the inline function ip6_dst_store may call dst_release.

I'm afraid that we really have to audit all dst_release callers,
both direct and indirect, as well as all places where dst is stored.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>