netdev
[Top] [All Lists]

[patch 14/18] s390/ctctty: replace schedule_timeout() with msleep_inte

To: jgarzik@xxxxxxxxx
Subject: [patch 14/18] s390/ctctty: replace schedule_timeout() with msleep_interruptible()
From: janitor@xxxxxxxxxxxxxx
Date: Sun, 31 Oct 2004 00:43:03 +0200
Cc: netdev@xxxxxxxxxxx, janitor@xxxxxxxxxxxxxx, nacc@xxxxxxxxxx, schwidefsky@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx


Any comments would be appreciated.

Description: Use msleep_interruptible() instead of
schedule_timeout() to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Acked-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
Signed-off-by: Maximilian Attems <janitor@xxxxxxxxxxxxxx>

---

 linux-2.6.10-rc1-max/drivers/s390/net/ctctty.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN 
drivers/s390/net/ctctty.c~msleep_interruptible-drivers_s390_net_ctctty 
drivers/s390/net/ctctty.c
--- 
linux-2.6.10-rc1/drivers/s390/net/ctctty.c~msleep_interruptible-drivers_s390_net_ctctty
     2004-10-24 17:05:21.000000000 +0200
+++ linux-2.6.10-rc1-max/drivers/s390/net/ctctty.c      2004-10-24 
17:05:21.000000000 +0200
@@ -1057,8 +1057,7 @@ ctc_tty_close(struct tty_struct *tty, st
        info->tty = 0;
        tty->closing = 0;
        if (info->blocked_open) {
-               set_current_state(TASK_INTERRUPTIBLE);
-               schedule_timeout(HZ/2);
+               msleep_interruptible(500);
                wake_up_interruptible(&info->open_wait);
        }
        info->flags &= ~(CTC_ASYNC_NORMAL_ACTIVE | CTC_ASYNC_CLOSING);
_

<Prev in Thread] Current Thread [Next in Thread>
  • [patch 14/18] s390/ctctty: replace schedule_timeout() with msleep_interruptible(), janitor <=