netdev
[Top] [All Lists]

[patch 02/18] net/3c505: replace schedule_timeout() with msleep()

To: jgarzik@xxxxxxxxx
Subject: [patch 02/18] net/3c505: replace schedule_timeout() with msleep()
From: janitor@xxxxxxxxxxxxxx
Date: Sun, 31 Oct 2004 00:42:22 +0200
Cc: netdev@xxxxxxxxxxx, janitor@xxxxxxxxxxxxxx, nacc@xxxxxxxxxx, pb@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx


Any comments would be appreciated.

Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Acked-by: Phil Blundell <pb@xxxxxxxxxxx>
Signed-off-by: Maximilian Attems <janitor@xxxxxxxxxxxxxx>

---

 linux-2.6.10-rc1-max/drivers/net/3c505.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff -puN drivers/net/3c505.c~msleep-drivers_net_3c505 drivers/net/3c505.c
--- linux-2.6.10-rc1/drivers/net/3c505.c~msleep-drivers_net_3c505       
2004-10-24 17:04:50.000000000 +0200
+++ linux-2.6.10-rc1-max/drivers/net/3c505.c    2004-10-24 17:04:50.000000000 
+0200
@@ -1327,8 +1327,7 @@ static int __init elp_sense(struct net_d
        if (orig_HSR & DIR) {
                /* If HCR.DIR is up, we pull it down. HSR.DIR should follow. */
                outb(0, dev->base_addr + PORT_CONTROL);
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(30*HZ/100);
+               msleep(300);
                if (inb_status(addr) & DIR) {
                        if (elp_debug > 0)
                                printk(notfound_msg, 2);
@@ -1337,8 +1336,7 @@ static int __init elp_sense(struct net_d
        } else {
                /* If HCR.DIR is down, we pull it up. HSR.DIR should follow. */
                outb(DIR, dev->base_addr + PORT_CONTROL);
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(30*HZ/100);
+               msleep(300);
                if (!(inb_status(addr) & DIR)) {
                        if (elp_debug > 0)
                                printk(notfound_msg, 3);
_

<Prev in Thread] Current Thread [Next in Thread>
  • [patch 02/18] net/3c505: replace schedule_timeout() with msleep(), janitor <=