| To: | romieu@xxxxxxxxxxxxx (Francois Romieu) |
|---|---|
| Subject: | Re: r8169: page allocation failure |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Sun, 17 Oct 2004 17:47:52 +1000 |
| Cc: | jkillius@xxxxxxxx, netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx, jgarzik@xxxxxxxxx |
| In-reply-to: | <20041016204848.GB21849@electric-eye.fr.zoreil.com> |
| Organization: | Core |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686)) |
Francois Romieu <romieu@xxxxxxxxxxxxx> wrote: > >> Oct 16 19:27:00 gate [<c022d975>] >> Oct 16 19:27:00 gate [<c022ddb2>] > > c022d8d0 T tcp_set_skb_tso_segs > c022d920 t tcp_fragment > c022dc70 t __pskb_trim_head Good catch. tcp_fragment's behaviour is broken when TSO is present. We can start with a list of n 1-mss fragments and tcp_fragment will end up allocating a continuous skb of n-1 mss bytes. It should instead allocate a new skb of 1 mss. I'll work on it. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC] Yield in netlink_broadcast when congested, Herbert Xu |
|---|---|
| Next by Date: | Re: r8169: page allocation failure, Herbert Xu |
| Previous by Thread: | Re: r8169: page allocation failure, Francois Romieu |
| Next by Thread: | Re: r8169: page allocation failure, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |