Re: [6/6]: jenkins hash for neigh

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> Please at least do something like this:
> 
> size = tbl->hash_mask + 1;
> if (tbl->entries > size) {
>        write_lock_bh(&tbl->lock);
>        neigh_hash_grow(tbl, size << 1);
>        write_unlock_bh(&tbl->lock);
> }
> 
> That'll at least kill the first race.  You can kill the race of
> growing into the same size by doing the if check again inside the
> locks.

Never mind.  Unless you do the check again inside the lock this
may actually shrink :)
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt