Re: 2.6.9-rc1-mm5: TCP oopses

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

David S. Miller <davem@xxxxxxxxxxxxx> wrote:
>
> @@ -968,11 +972,17 @@
>                return -EAGAIN;
> 
>        if (skb->len > cur_mss) {
> +               int old_factor = TCP_SKB_CB(skb)->tso_factor;
> +               int new_factor;
> +
>                if (tcp_fragment(sk, skb, cur_mss))
>                        return -ENOMEM; /* We'll try again later. */
> 
>                /* New SKB created, account for it. */
> -               tcp_inc_pcount(&tp->packets_out, skb);
> +               new_factor = TCP_SKB_CB(skb)->tso_factor;
> +               tcp_dec_pcount_explicit(&tp->packets_out,
> +                                       new_factor - old_factor);

That should be tcp_inc_pcount_explicit.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt