We give the fragments in that order to ensure they are all setup before
hardware starts looking at them.
I can fix up the coding style issue in another patch. That has been
there since day 1 and is not related to this patch.
-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@xxxxxxxx]
Sent: Monday, October 24, 2005 2:21 PM
To: Ayaz Abdulla
Cc: Jeff Garzik; Manfred Spraul; Netdev
Subject: Re: [PATCH 2/2] forcedeth: scatter gather and segmentation
offload support
On Mon, 24 Oct 2005 12:48:07 -0400
Ayaz Abdulla <aabdulla@xxxxxxxxxx> wrote:
> Jeff,
>
> I made the changes you requested. Here is the new patch.
>
> Thanks,
> Ayaz
>
> Signed-off-By: Ayaz Abdulla <aabdulla@xxxxxxxxxx>
>
There are really three patches in here.
1. Use netdev_priv (trivial)
2. scatter/gather support
3. TSO support
Why do you set the fragments up in reverse order? Going backwards is
usually slow on most code.
The kernel coding style is to use lower case in local variable names
(Flags)
and structure elements (PacketBuffer, FlagLen).
--
Stephen Hemminger <shemminger@xxxxxxxx>
OSDL http://developer.osdl.org/~shemminger
|