netdev
[Top] [All Lists]

RE: [2.4] e1000 leaking pci mappings on rx errors?

To: "Olof Johansson" <olof@xxxxxxxxxxxxxx>
Subject: RE: [2.4] e1000 leaking pci mappings on rx errors?
From: "Feldman, Scott" <scott.feldman@xxxxxxxxx>
Date: Mon, 12 Jan 2004 15:36:32 -0800
Cc: <netdev@xxxxxxxxxxx>, "cramerj" <cramerj@xxxxxxxxx>, <milliner@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Thread-index: AcPZTX7knqriL1FqQTWkkL94kRWzsAAFxEYg
Thread-topic: [2.4] e1000 leaking pci mappings on rx errors?
> Also, I noticed it's leaking quite fast, and even before any 
> RX errors are shown. So my previous guess w.r.t. cause and effect
might 
> have been wrong:

Ok, most of the changes to the driver are on the Tx side.  Add this to
5.2.20 and let's see if we're hitting this path.  Maybe there is still
something wrong with the Tx unwind case where we run out of resources:

diff -Nuarp e1000-5.2.20/src/e1000_main.c
e1000-5.2.20-mod/src/e1000_main.c
--- e1000-5.2.20/src/e1000_main.c       2003-09-30 23:22:19.000000000
-0700
+++ e1000-5.2.20-mod/src/e1000_main.c   2004-01-12 16:09:06.000000000
-0800
@@ -1837,6 +1837,8 @@ e1000_xmit_frame(struct sk_buff *skb, st
        if((count = e1000_tx_map(adapter, skb, first)))
                e1000_tx_queue(adapter, count, tx_flags);
        else {
+               static int stops = 0;
+               printk(KERN_ERR "stopping queue %d\n", ++stops);
                netif_stop_queue(netdev);
                return 1;
        }


<Prev in Thread] Current Thread [Next in Thread>