netdev
[Top] [All Lists]

RE: [PATCH] fix BUG in tg3_tx

To: "Greg Banks" <gnb@xxxxxxx>
Subject: RE: [PATCH] fix BUG in tg3_tx
From: "Michael Chan" <mchan@xxxxxxxxxxxx>
Date: Wed, 26 May 2004 10:43:10 -0700
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Thread-index: AcRDO0IT3j2IJqVKQOiSUOtmsz08ewACyIgA
Thread-topic: [PATCH] fix BUG in tg3_tx
> On a related note, is there a good reason why the tg3 driver 
> uses the on-chip SRAM send ring by default instead of the 
> host send ring? This seems like it would dramatically 
> increase the PIO load on the chipset for some of the 
> workloads I'm interested in.
> 

I can only speak for the Broadcom bcm5700 driver. We used to use NIC
send BDs by default before zero copy transmit and TSO were implemented
in the kernel. Using only one BD per packet at that time, we found that
performance on some machines were sometimes slightly better. Especially
with logic to save some PIO when some of the fields in the BD have not
changed. The driver has now been changed to use host send BDs to perform
better with zero copy and especially TSO where you may need many BDs per
packet. I would recommend tg3 to make the switch also.

Michael



<Prev in Thread] Current Thread [Next in Thread>