"David S. Miller" wrote:
>
> On Tue, 22 Mar 2005 18:50:36 -0500
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> > Sorry, I still disagree. We need to think about how to handle this
> > situation for -all- drivers and -all- users, not just tg3.
>
> When you come up with something that doesn't require the
> users to ask around and report stuff when MSI doesn't work,
> let me know.
>
> But for now let's hold off on the tg3 MSI support, ok?
>
>
Jeff, I understand your point of view which is from the kernel development
perspective. For us, we have to consider the user's perspective when he is
trying to figure out why things are not working. Let's see if we can address
your concerns with the following:
#1. Keep the msi test but add a message telling the user to report to the PCI
maintainer when msi test fails, as David suggested.
#2. Do the msi test and if it fails, just print a message telling the user to
disable MSI some other way and report to PCI maintainer. This will at least
identify the potential problem to the user.
Michael
|