netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

RE: Fix fallout from tg3_readphy() value is zero on error

from [Michael Chan] [Permanent Link][Original]
To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: RE: Fix fallout from tg3_readphy() value is zero on error
From: "Michael Chan" <mchan@xxxxxxxxxxxx>
Date: Tue, 15 Feb 2005 10:18:14 -0800
Cc: peterc@xxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Thread-index: AcUTgjDplSoOuQ0sTkq/1tePl0nJgwAB94xA
Thread-topic: Fix fallout from tg3_readphy() value is zero on error 
> @@ -793,9 +799,11 @@
>  
>       tg3_writephy(tp, MII_TG3_CTRL, phy9_orig);
>  
> -     tg3_readphy(tp, MII_TG3_EXT_CTRL, &reg32);
> -     reg32 &= ~0x3000;
> -     tg3_writephy(tp, MII_TG3_EXT_CTRL, reg32);
> +     if (tg3_readphy(tp, MII_TG3_EXT_CTRL, &reg32)) {
> +             reg32 &= ~0x3000;
> +             tg3_writephy(tp, MII_TG3_EXT_CTRL, reg32);
> +     } else if (!err)
> +             err = -EBUSY;
>  
>       return err;
>  }

Shouldn't this be:

> +     if (!tg3_readphy(tp, MII_TG3_EXT_CTRL, &reg32)) {
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH 1/9] Use netdev_priv in NETROM and ROSE, David S. Miller
Next by Date:  Re: [PATCH] fix typo in include/linux/socket.h, David S. Miller
Previous by Thread:  Re: Fix fallout from tg3_readphy() value is zero on error, David S. Miller
Next by Thread:  Re: Fix fallout from tg3_readphy() value is zero on error, David S. Miller
Indexes:  [Date] [Thread] [Top] [All Lists]