| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | RE: [PATCH 2.6.10] tg3: Fix TSO for 5750 |
| From: | "Michael Chan" <mchan@xxxxxxxxxxxx> |
| Date: | Mon, 24 Jan 2005 14:59:43 -0800 |
| Cc: | netdev@xxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| Thread-index: | AcUCZk80D+kWSdMDT6OT6+gphQGyzAAAJM6Q |
| Thread-topic: | [PATCH 2.6.10] tg3: Fix TSO for 5750 |
"David S. Miller" wrote:
> If we've created this new TG3_FLG2_HW_TSO flag, we should
> eliminate all 5750 tests which are just checking for that.
>
> For example, this patch leaves the following test:
>
> - if (GET_ASIC_REV(tp->pci_chip_rev_id) ==
> ASIC_REV_5705) {
> + if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO) ||
> + (GET_ASIC_REV(tp->pci_chip_rev_id) ==
> ASIC_REV_5705)) {
>
> Here, just checking the TG3_FLG3_HW_TSO flag would suffice.
>
>
>
This particular test is for 5705 or 5750. 5705 is a little different from
5750 in terms of TSO.
But I plan to introduce another flag for 5705 and 5750 as these 2 chips have
other things in common. This will be done in a different patch.
Michael
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: skb_checksum_help, Herbert Xu |
|---|---|
| Next by Date: | Re: skb_checksum_help, Thomas Graf |
| Previous by Thread: | Re: [PATCH 2.6.10] tg3: Fix TSO for 5750, David S. Miller |
| Next by Thread: | Re: [PATCH 2.6.10] tg3: Fix TSO for 5750, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |