Re: [RFT] merged 8139too NAPI

[OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>]

Stephen Hemminger <shemminger@xxxxxxxx> writes:

> +     spin_lock_bh(&tp->rx_lock);
>       /* disable Tx ASAP, if not already */
>       tmp8 = RTL_R8 (ChipCmd);
>       if (tmp8 & CmdTxEnb)
> @@ -1679,6 +1682,7 @@
>  
>       /* ...and finally, reset everything */
>       rtl8139_hw_start (dev);
> +     spin_unlock_bh(&tp->rx_lock);

->tx_timeout is on timer softirq context. So softirq was disabled already.
Or Is this for future changes?

> +     /* Check uncommon events with one test. */
> +     if (unlikely(status & (PCIErr | PCSTimeout | RxUnderrun | RxOverflow)))
> +             rtl8139_weird_interrupt (dev, tp, ioaddr,
> +                                      status, link_changed);

I couldn't find this on previous email, rtl8139_weird_interrupt was changing. 

        if (unlikely(status & (PCIErr|PCSTimeout|RxUnderrun|RxErr|RxFIFOOver)))
                rtl8139_weird_interrupt(dev, tp, ioaddr, status, link_changed);

It should check the above status.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>