netdev
[Top] [All Lists]

Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1

To: Andrew Morton <akpm@xxxxxxxx>
Subject: Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000
From: Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx>
Date: Wed, 18 May 2005 08:55:39 -0700
Cc: Christoph Lameter <christoph@xxxxxxxxxxx>, davem@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, shai@xxxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=uOfq1AobFJDdj3khrryaBkIxBRIX87TVGVHOpjve9PwXOIo8rRxUR/8SjTjdETF9+TwgfH2OV4MrEOmL3JE0HLs/gNsUpD7MNEfXHzx7Oyv1/e3sU2Srft4vqEePydr8AVtYEK+l4REdCfqx7qYG+zr5FrM4qVZVDbRwGS7TN9U=
In-reply-to: <20050517215845.2f87be2f.akpm@osdl.org>
References: <Pine.LNX.4.62.0505171854490.20408@graphe.net> <20050517190343.2e57fdd7.akpm@osdl.org> <Pine.LNX.4.62.0505171941340.21153@graphe.net> <20050517.195703.104034854.davem@davemloft.net> <Pine.LNX.4.62.0505172125210.22920@graphe.net> <20050517215845.2f87be2f.akpm@osdl.org>
Reply-to: Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On 5/17/05, Andrew Morton <akpm@xxxxxxxx> wrote:
> I think the e1000 driver is being a bit insane there.  I figure that
Do you mean insane to use vmalloc?

> sizeof(struct e1000_buffer) is 28 on 64-bit, so even with 4k pagesize we'll
> always succeed in being able to support a 32k/32 = 1024-entry Tx ring.
> 
> Is there any real-world reason for wanting larger ring sizes than that?
> 
> 
We have had cases where allocation of 32K of memory (via kmalloc) fails. 

ganesh.


<Prev in Thread] Current Thread [Next in Thread>