netdev
[Top] [All Lists]

Re: [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver

To: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver
From: Roland Dreier <roland@xxxxxxxxxxx>
Date: Mon, 20 Dec 2004 08:45:49 -0800
Cc: linux-kernel@xxxxxxxxxxxxxxx, openib-general@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041220.155836.75677852.yoshfuji@linux-ipv6.org> (YOSHIFUJI Hideaki's message of "Mon, 20 Dec 2004 15:58:36 +0900 (JST)")
References: <200412192215.69tnzAhGIT1vQGLF@topspin.com> <200412192215.fZX1ZQqQD4QGkKcF@topspin.com> <20041220.155836.75677852.yoshfuji@linux-ipv6.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through Obscurity, linux)
    YOSHIFUJI> above entries does not seem to appropriate for enum
    YOSHIFUJI> (than #define).

As Arnd mentioned, I thought enum values were preferred to using the
preprocessor.  What's the advantage of converting to macros (which
have no type, are invisible to the compiler, etc)?

Thanks,
  Roland

<Prev in Thread] Current Thread [Next in Thread>