netdev
[Top] [All Lists]

RE: RFC: NAPI packet weighting patch

To: <hadi@xxxxxxxxxx>, "Stephen Hemminger" <shemminger@xxxxxxxx>
Subject: RE: RFC: NAPI packet weighting patch
From: "Ronciak, John" <john.ronciak@xxxxxxxxx>
Date: Tue, 7 Jun 2005 09:23:32 -0700
Cc: "Williams, Mitch A" <mitch.a.williams@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, <mchan@xxxxxxxxxxxx>, <buytenh@xxxxxxxxxxxxxx>, <jdmason@xxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <Robert.Olsson@xxxxxxxxxxx>, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, "Brandeburg, Jesse" <jesse.brandeburg@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Thread-index: AcVrXegOZHm18G6dQvuhFRXgNm9BYQAHZMnQ
Thread-topic: RFC: NAPI packet weighting patch
>> 
> To the intel folks: shouldnt someone be investigating why this is so?

This is why we started all of this.  We have data that is showing this
issue where our over all performance is best in class and yet we can
make it better by changing things like the weight value.

There also seems to be some misconceptions about changing the weight
value.  It actually improves the performance of other drivers as well.
Not as much as it improves the e1000 performance but it does seem to
help others as well.  We (Intel) have to be careful talking about
competitors performance so we just refer to them as competitors in these
threads.  So it is not just e1000 who benefits from the lower weight
values.  One thing it is doing for e1000 right now is that it is
stopping the e1000 from dropping frames which is part of why it's
helping the e1000 more (I think).

I agree that we need to bottom out on this and it's why we are
dedicating the time and resources to this effort.  We also appreciate
all the effort to help resolve this as well.  This should result in a
better performing 2.6 stack and drivers.  The new TSO code is a big step
in that direction as well.

Cheers,
John




<Prev in Thread] Current Thread [Next in Thread>