netdev
[Top] [All Lists]

RE: RFC: NAPI packet weighting patch

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: RE: RFC: NAPI packet weighting patch
From: "Ronciak, John" <john.ronciak@xxxxxxxxx>
Date: Mon, 6 Jun 2005 13:29:50 -0700
Cc: <mchan@xxxxxxxxxxxx>, <hadi@xxxxxxxxxx>, <buytenh@xxxxxxxxxxxxxx>, "Williams, Mitch A" <mitch.a.williams@xxxxxxxxx>, <jdmason@xxxxxxxxxx>, <shemminger@xxxxxxxx>, <netdev@xxxxxxxxxxx>, <Robert.Olsson@xxxxxxxxxxx>, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, "Brandeburg, Jesse" <jesse.brandeburg@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Thread-index: AcVq0KInJf0GW6tXQUu/BgSh9BGIAQABPK1A
Thread-topic: RFC: NAPI packet weighting patch
>       If you force the e1000 driver to do RX replenishment every N
>       packets it should reduce the packet drops the same (in the
>       single NIC case) as if you reduced the dev->weight to that
>       same value N.

But this isn't what we are seeing.  Even if we just reduce the weight
value to 32 from 64, all of the drops go away.  So there seems to be
other things affecting this.

We are just talking about single NIC testing at this point.  I agree
that single and multi-NIC results different issues and we will need to
test this as well with whatever we come up with out of this.

I also like your idea about the weight value being adjusted based on
real work done using some measurable metric.  This seems like a good
path to explore as well.

Cheers,
John




<Prev in Thread] Current Thread [Next in Thread>