netdev
[Top] [All Lists]

RE: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to alloca

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: RE: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to allocate driver local data structures
From: "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>
Date: Fri, 29 Oct 2004 05:50:45 -0700
Cc: <jgarzik@xxxxxxxxx>, "netdev" <netdev@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Thread-index: AcS9sOvP+I4++ZzkTkWAHohvq1hNkAABGcfA
Thread-topic: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to allocate driver local data structures
This is a trade-off between space allocated via kmalloc and vmalloc. My
understanding is that kmalloc space is more limited than vmalloc. Is
this incorrect?

With the original implementation that used kmalloc for all allocations
in the driver, I have noticed allocation failures when the ring sizes
were set to 4096. Switching the allocation of this space from kmalloc to
vmalloc guarantees successful allocation.

What am I missing?

Ganesh.

-----Original Message-----
From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] 
Sent: Friday, October 29, 2004 5:15 AM
To: Venkatesan, Ganesh
Cc: jgarzik@xxxxxxxxx; netdev
Subject: Re: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc
to allocate driver local data structures

this uses up vmalloc space and thus is a regression.



<Prev in Thread] Current Thread [Next in Thread>