netdev
[Top] [All Lists]

Re: [PATCH] forcedeth: Add support for 64-bit dma addresses.

To: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] forcedeth: Add support for 64-bit dma addresses.
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Fri, 22 Jul 2005 16:56:35 -0400
Cc: Netdev <netdev@xxxxxxxxxxx>, Ayaz Abdulla <AAbdulla@xxxxxxxxxx>
In-reply-to: <42E15AE7.3020304@colorfullife.com>
References: <42E15AE7.3020304@colorfullife.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720)
Manfred Spraul wrote:
+       if (id->driver_data & DEV_HAS_HIGH_DMA) {
+               np->desc_ver = DESC_VER_3;
+               dev->features |= NETIF_F_HIGHDMA;
+               if (pci_set_dma_mask(pci_dev, 0x0000007fffffffffULL)) {
+                       if (pci_set_dma_mask(pci_dev, 0xffffffffULL))
+                               goto out_relreg;
+               }


setting of NETIF_F_HIGHDMA is wrong, if 64-bit set-dma-mask fails.


<Prev in Thread] Current Thread [Next in Thread>