Re: 2.6.12-rc5-mm2: "bic unavailable using TCP reno" messages

[Baruch Even <baruch@xxxxxxxxx>]

Stephen Hemminger wrote:
> Here is what I am working on as better way to make the sysctl selection.
> I am not totally happy with the way the default congestion control value is 
> determined
> by the load order. But it does seem good that if you load "tcp_xxx" module 
> and it
> registers it becomes the default.

Looks good.

> @@ -120,6 +117,52 @@ static int ipv4_sysctl_forward_strategy(
>       return 1;
>  }
>  
> +static int proc_tcp_congestion_control(ctl_table *ctl, int write, struct 
> file * filp,
> +                                    void __user *buffer, size_t *lenp, 
> loff_t *ppos)
> +{
> +     char val[TCP_CA_NAME_MAX];
> +     ctl_table tbl = {
> +             .data = val,
> +             .maxlen = TCP_CA_NAME_MAX,
> +     };
> +     int ret;
> +
> +     tcp_get_congestion_control(val);

Maybe we should call this tcp_get_current_congestion_control(), the
current name implies (to me) that you give it a name and it returns the
the ca struct. get_current might also just return the current one and
the strcpy can be done here.

Otherwise you probably should document the tcp_get_congestion_control()
to say what size of string it accepts.

Baruch