| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: netfilter6: ICMPv6 type 143 doesn't match |
| From: | Patrick McHardy <kaber@xxxxxxxxx> |
| Date: | Fri, 06 May 2005 16:39:51 +0200 |
| Cc: | davem@xxxxxxxxxxxxx, dlstevens@xxxxxxxxxx, laforge@xxxxxxxxxxxx, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx, pb@xxxxxxxxxxxx, usagi-users@xxxxxxxxxxxxxx, yasuyuki.kozakai@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx |
| In-reply-to: | <E1DU2mw-0000UK-00@gondolin.me.apana.org.au> |
| References: | <E1DU2mw-0000UK-00@gondolin.me.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.7) Gecko/20050420 Debian/1.7.7-2 |
Herbert Xu wrote:
> Patrick McHardy <kaber@xxxxxxxxx> wrote:
>>+ err = dev->hard_header(skb, dev, ETH_P_IPV6, ha, NULL,
>>skb->len);
>>+ if (err < 0) {
>>+ IP6_INC_STATS(IPSTATS_MIB_OUTDISCARDS);
>
> You're now incrementing this twice since the callers will also
> increment this.
Thanks, I've removed the line again.
Regards
Patrick
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] ipvs: add and reorder bh locks after moving to keventd, Julian Anastasov |
|---|---|
| Next by Date: | Re: [RFC] textsearch infrastructure + skb_find_text(), Thomas Graf |
| Previous by Thread: | Re: netfilter6: ICMPv6 type 143 doesn't match, Herbert Xu |
| Next by Thread: | [IPV4]: multipath_wrandom.c GPF fixes, Patrick McHardy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |