netdev
[Top] [All Lists]

Re: patch: Action repeat

To: hadi@xxxxxxxxxx
Subject: Re: patch: Action repeat
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sat, 30 Apr 2005 20:13:11 +0200
Cc: netdev <netdev@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <1114882045.8929.123.camel@localhost.localdomain>
References: <1114879817.8929.117.camel@localhost.localdomain> <4273BB30.1050402@trash.net> <4273BBAA.6060405@trash.net> <1114882045.8929.123.camel@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.6) Gecko/20050324 Debian/1.7.6-1
jamal wrote:
Actions can set it. Theres one in particular that i havent submitted yet that sets it
amongst other items (depending on policy). We discussed this a while
back when talking about ematches etc.

Since it only has such a short lifetime (action function sets it, tcf_action_exec() clears it after changing classification result), it would be less wasteful to just pass the classification result to the actions. This would also avoid that skbs with tc_classid already set can reach tcf_action_exec() (for example through mirred).

What do you think?

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>