netdev
[Top] [All Lists]

Re: [NET] Add missing newline for skb_*_panic

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [NET] Add missing newline for skb_*_panic
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Fri, 22 Apr 2005 00:11:51 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050421050815.GA23133@gondor.apana.org.au>
References: <20050421050815.GA23133@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.6) Gecko/20050324 Debian/1.7.6-1
Herbert Xu wrote:
Here is a trivial patch to make the skb_under_panic/skb_over_panic
messages to look nicer.  As it is their printk is joined onto the
first line of the BUG output because of a missing newline.

How about this one instead? Besides the missing newlines, it adds head/data/tail/end to the output, which can give valuable hints about what happend before.

Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
===== net/core/skbuff.c 1.44 vs edited =====
--- 1.44/net/core/skbuff.c      2005-03-11 21:32:26 +01:00
+++ edited/net/core/skbuff.c    2005-04-22 00:08:09 +02:00
@@ -86,8 +86,10 @@
  */
 void skb_over_panic(struct sk_buff *skb, int sz, void *here)
 {
-       printk(KERN_INFO "skput:over: %p:%d put:%d dev:%s",
-               here, skb->len, sz, skb->dev ? skb->dev->name : "<NULL>");
+       printk(KERN_INFO "skb_over_panic: text:%p len:%d put:%d head:%p "
+                        "data:%p tail:%p end:%p dev:%s\n",
+              here, skb->len, sz, skb->head, skb->data, skb->tail, skb->end,
+              skb->dev ? skb->dev->name : "<NULL>");
        BUG();
 }
 
@@ -102,8 +104,10 @@
 
 void skb_under_panic(struct sk_buff *skb, int sz, void *here)
 {
-       printk(KERN_INFO "skput:under: %p:%d put:%d dev:%s",
-               here, skb->len, sz, skb->dev ? skb->dev->name : "<NULL>");
+       printk(KERN_INFO "skb_under_panic: text:%p len:%d put:%d head:%p "
+                        "data:%p tail:%p end:%p dev:%s\n",
+              here, skb->len, sz, skb->head, skb->data, skb->tail, skb->end,
+              skb->dev ? skb->dev->name : "<NULL>");
        BUG();
 }
 
<Prev in Thread] Current Thread [Next in Thread>