Re: Fw: [Bugme-new] [Bug 4381] New: When i try to start a pppoe conn., crash at net/core/skbuff.c:91

[Patrick McHardy <kaber@xxxxxxxxx>]

Herbert Xu wrote:
> Patrick McHardy <kaber@xxxxxxxxx> wrote:
>
> > ===== drivers/net/ppp_async.c 1.26 vs edited =====
> > --- 1.26/drivers/net/ppp_async.c        2005-01-21 06:02:12 +01:00
> > +++ edited/drivers/net/ppp_async.c      2005-03-23 03:15:31 +01:00
> > @@ -183,6 +183,7 @@
> >       ap->chan.private = ap;
> >       ap->chan.ops = &async_ops;
> >       ap->chan.mtu = PPP_MRU;
> > +       ap->chan.hdrlen = 2;
> >       err = ppp_register_channel(&ap->chan);
>
>
> I'm not sure whether this could cause the original crash that we saw.
> If ap->chan.hdrlen is not set then it should be zero.  It being zero
> should not cause skb_over_panic to trigger in ppp_write, should it?

You're right, I missed the memset().

Regards
Patrick