Re: [patch 03/13] drivers/net/myri

netdev

Re: [patch 03/13] drivers/net/myri_code.h cleanup

To:	akpm@xxxxxxxx, domen@xxxxxxxxxxxx
Subject:	Re: [patch 03/13] drivers/net/myri_code.h cleanup
From:	Jeff Garzik <jgarzik@xxxxxxxxx>
Date:	Tue, 22 Mar 2005 17:49:30 -0500
Cc:	davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<200503152222.j2FMMZ1i016799@shell0.pdx.osdl.net>
References:	<200503152222.j2FMMZ1i016799@shell0.pdx.osdl.net>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

akpm@xxxxxxxx wrote:

From: Domen Puncer <domen@xxxxxxxxxxxx>

Replace

        static unsigned char lanai4_data[20472] __initdata = {
                <thousands of 0x00's>
        }

with

static unsigned char lanai4_data[20472] __initdata = { };


Proper change:  Don't bother with an initializer at all.  it's static.

        Jeff

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 03/13] drivers/net/myri_code.h cleanup, akpm Re: [patch 03/13] drivers/net/myri_code.h cleanup, Jeff Garzik <=

Previous by Date:	Re: [IPSEC] Too many SADs!, Scott Mcdermott
Next by Date:	Re: [PATCH 2.6.11] WE-18 (aka WPA), Jeff Garzik
Previous by Thread:	[patch 03/13] drivers/net/myri_code.h cleanup, akpm
Next by Thread:	[patch 08/13] Log full of "ing_filter: fixed ippp2 out ippp2", akpm
Indexes:	[Date] [Thread] [Top] [All Lists]