netdev
[Top] [All Lists]

Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_dat

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data
From: Mika Penttilä <mika.penttila@xxxxxxxxxxx>
Date: Mon, 21 Mar 2005 23:29:58 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, YOSHIFUJI Hideaki <yoshfuji@xxxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050321202804.GA3106@gondor.apana.org.au>
References: <20050214221607.GC18465@gondor.apana.org.au> <20050306213214.7d8a143d.davem@davemloft.net> <20050307103536.GB7137@gondor.apana.org.au> <20050308102741.GA23468@gondor.apana.org.au> <20050314102614.GA9610@gondor.apana.org.au> <20050314105313.GA21001@gondor.apana.org.au> <20050314111002.GA29156@gondor.apana.org.au> <20050315091904.GA6256@gondor.apana.org.au> <20050316113149.GA10960@gondor.apana.org.au> <423EF2CF.7020403@kolumbus.fi> <20050321202804.GA3106@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020
Herbert Xu wrote:

On Mon, Mar 21, 2005 at 06:14:07PM +0200, Mika Penttil? wrote:


Shouldn't ip_output also use the path variant, dst_mtu(skb->dst->path), it's surely after ipsec- processing?



That's the reason why it shouldn't use dst->path. The only time you should use dst_mtu(dst->path) is when dst may contain IPsec AND you need the MTU outside IPsec.

In this case dst cannot contain IPsec so dst_mtu(dst) is correct.

Cheers,


ok I see it now, but this is really easy to get wrong...

Thanks,
Mika


<Prev in Thread] Current Thread [Next in Thread>