Re: Replace send_unreach with icmp

netdev

Re: Replace send_unreach with icmp_send

To:	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: Replace send_unreach with icmp_send
From:	Patrick McHardy <kaber@xxxxxxxxx>
Date:	Tue, 15 Mar 2005 21:48:53 +0100
Cc:	"David S. Miller" <davem@xxxxxxxxxxxxx>, kuznet@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<20050315204006.GB22349@gondor.apana.org.au>
References:	<20050307103536.GB7137@gondor.apana.org.au> <20050308102741.GA23468@gondor.apana.org.au> <20050314102614.GA9610@gondor.apana.org.au> <20050314105313.GA21001@gondor.apana.org.au> <20050314111002.GA29156@gondor.apana.org.au> <20050315091904.GA6256@gondor.apana.org.au> <20050315095837.GA7130@gondor.apana.org.au> <20050315100522.GA7275@gondor.apana.org.au> <20050315102450.0f3f1618.davem@davemloft.net> <42373142.6090902@trash.net> <20050315204006.GB22349@gondor.apana.org.au>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1

Herbert Xu wrote:

Well it isn't terribly difficult to create a new version of icmp_send
that does xrlim conditionally.  icmp_send/ipt_REJECT can then call that
function.

The main reason I'm looking at getting rid of send_unreach is because
having two implementations of the same code often leads to bugs.  In
fact, as it is there are multiple IPsec-related bugs in the ipt_REJECT
code.


Ok. I can't see any different reason to keep it, so go ahead. I'll take
care of the xrlim stuff later.

Regards
Patrick

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
*[12/] [IPSEC] Handle local_df in IPv4*, (continued)* *[12/] [IPSEC] Handle local_df in IPv4*, Herbert Xu* *[13/] [IPV4] Fix room calculation in icmp_send*, Herbert Xu* *[14/] [IPV6] Reload skb->dst after xfrm6_route_forward*, Herbert Xu* *Re: [14/] [IPV6] Reload skb->dst after xfrm6_route_forward*, David S. Miller* *[15/] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data*, Herbert Xu* *[16/] [INET] Take IPsec overhead into account in tunnels*, Herbert Xu* *[17/] [NET] Replace dst_pmtu with dst_mtu*, Herbert Xu* *Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, David S. Miller* *Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, Patrick McHardy* Replace send_unreach with icmp_send, Herbert Xu Re: Replace send_unreach with icmp_send, Patrick McHardy <= [IPV4] Make ipt_REJECT use icmp_send again, Herbert Xu Re: [IPV4] Make ipt_REJECT use icmp_send again, Patrick McHardy Re: [IPV4] Make ipt_REJECT use icmp_send again, David S. Miller [IPV4] Send TCP reset through dst_output in ipt_REJECT, Herbert Xu Re: [IPV4] Send TCP reset through dst_output in ipt_REJECT, David S. Miller *Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, Herbert Xu* *Re: [16/] [INET] Take IPsec overhead into account in tunnels*, Lennert Buytenhek* *Re: [16/] [INET] Take IPsec overhead into account in tunnels*, Herbert Xu* *Re: [16/] [INET] Take IPsec overhead into account in tunnels*, David S. Miller* *[21/] [IPv4] Fix MTU check in ipmr_queue_xmit*, Herbert Xu*

Previous by Date:	Replace send_unreach with icmp_send, Herbert Xu
Next by Date:	Re: [PATCH] Optimize loopback stats, Nivedita Singhvi
Previous by Thread:	Replace send_unreach with icmp_send, Herbert Xu
Next by Thread:	[IPV4] Make ipt_REJECT use icmp_send again, Herbert Xu
Indexes:	[Date] [Thread] [Top] [All Lists]