Re: [17/*] [NET] Replace dst_pmtu with dst

netdev

Re: [17/*] [NET] Replace dst_pmtu with dst_mtu

To:	"David S. Miller" <davem@xxxxxxxxxxxxx>
Subject:	Re: [17/*] [NET] Replace dst_pmtu with dst_mtu
From:	Patrick McHardy <kaber@xxxxxxxxx>
Date:	Tue, 15 Mar 2005 20:02:26 +0100
Cc:	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, kuznet@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, Netfilter Development Mailinglist <netfilter-devel@xxxxxxxxxxxxxxxxxxx>
In-reply-to:	<20050315102450.0f3f1618.davem@davemloft.net>
References:	<20050214221433.GB18465@gondor.apana.org.au> <20050214221607.GC18465@gondor.apana.org.au> <20050306213214.7d8a143d.davem@davemloft.net> <20050307103536.GB7137@gondor.apana.org.au> <20050308102741.GA23468@gondor.apana.org.au> <20050314102614.GA9610@gondor.apana.org.au> <20050314105313.GA21001@gondor.apana.org.au> <20050314111002.GA29156@gondor.apana.org.au> <20050315091904.GA6256@gondor.apana.org.au> <20050315095837.GA7130@gondor.apana.org.au> <20050315100522.GA7275@gondor.apana.org.au> <20050315102450.0f3f1618.davem@davemloft.net>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1

David S. Miller wrote:

On Tue, 15 Mar 2005 21:05:22 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

At this point the only remaining user of dst_pmtu is ipt_REJECT which
will go away either when we use icmp_send in there or when I replace
it with dst_mtu.

Yes, I saw that posting on netfilter-devel where you asked Rusty
why icmp_send() wasn't directly used even though it appears it
should be.


I would prefer to keep it seperately. I have planned to remove xrlim
from ipt_REJECT so it behaves similar for TCP and ICMP. Limits should
then be handled by the limit match. This can't be done if we switch to
icmp_send().

Regards
Patrick

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
*Re: [11/] [NET] Move dst_release out of dst->ops->check*, (continued)* *Re: [11/] [NET] Move dst_release out of dst->ops->check*, YOSHIFUJI Hideaki / 吉藤英明* *Re: [11/] [NET] Move dst_release out of dst->ops->check*, David S. Miller* *[12/] [IPSEC] Handle local_df in IPv4*, Herbert Xu* *[13/] [IPV4] Fix room calculation in icmp_send*, Herbert Xu* *[14/] [IPV6] Reload skb->dst after xfrm6_route_forward*, Herbert Xu* *Re: [14/] [IPV6] Reload skb->dst after xfrm6_route_forward*, David S. Miller* *[15/] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data*, Herbert Xu* *[16/] [INET] Take IPsec overhead into account in tunnels*, Herbert Xu* *[17/] [NET] Replace dst_pmtu with dst_mtu*, Herbert Xu* *Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, David S. Miller* *Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, Patrick McHardy* <= Replace send_unreach with icmp_send, Herbert Xu Re: Replace send_unreach with icmp_send, Patrick McHardy [IPV4] Make ipt_REJECT use icmp_send again, Herbert Xu Re: [IPV4] Make ipt_REJECT use icmp_send again, Patrick McHardy Re: [IPV4] Make ipt_REJECT use icmp_send again, David S. Miller [IPV4] Send TCP reset through dst_output in ipt_REJECT, Herbert Xu Re: [IPV4] Send TCP reset through dst_output in ipt_REJECT, David S. Miller *Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, Herbert Xu* *Re: [16/] [INET] Take IPsec overhead into account in tunnels*, Lennert Buytenhek* *Re: [16/] [INET] Take IPsec overhead into account in tunnels*, Herbert Xu*

Previous by Date:	Re: [PATCH] no more rwlock_t inside tcp_ehash_bucket, David S. Miller
Next by Date:	Re: Constant errors with pktgen, cliff white
Previous by Thread:	*Re: [17/] [NET] Replace dst_pmtu with dst_mtu*, David S. Miller*
Next by Thread:	Replace send_unreach with icmp_send, Herbert Xu
Indexes:	[Date] [Thread] [Top] [All Lists]