netdev
[Top] [All Lists]

Re: [PATCH 4/5] r8169: ethtool message level control

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] r8169: ethtool message level control
From: Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>
Date: Sat, 12 Mar 2005 15:12:28 +0000
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050312143324.GA15154@electric-eye.fr.zoreil.com>
References: <20050309113402.05d25e49@dxpl.pdx.osdl.net> <4232DA4F.5050804@phekda.gotadsl.co.uk> <20050312143324.GA15154@electric-eye.fr.zoreil.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020
Hello.

Francois Romieu wrote:
[snip]
I'll fix it and convert the remaining printk as well during the merge
of your version with this one.

I think you should disregard my patch and just use Stephen's. His patch is what I was hoping to end up with, after fixing my patch. ;)


Likewise for my statistics patch - please use Stephen's, if you're happy with setting up the DMA mappings on each get_ethtool_stats call.

Thanks, bye, Rich =]

--
Richard Dawe [ http://homepages.nildram.co.uk/~phekda/richdawe/ ]

"You can't evaluate a man by logic alone."
  -- McCoy, "I, Mudd", Star Trek

<Prev in Thread] Current Thread [Next in Thread>