netdev
[Top] [All Lists]

Re: netif_rx packet dumping

To: Andi Kleen <ak@xxxxxx>
Subject: Re: netif_rx packet dumping
From: Baruch Even <baruch@xxxxxxxxx>
Date: Tue, 08 Mar 2005 18:01:01 +0000
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <m1y8cykr7i.fsf@muc.de>
References: <20050303123811.4d934249@dxpl.pdx.osdl.net> <42278122.6000000@ev-en.org> <20050303133659.0d224e61.davem@davemloft.net> <42278554.2090902@ev-en.org> <20050303135718.2e1a0170.davem@davemloft.net> <422DC7CE.2040800@ev-en.org> <m1y8cykr7i.fsf@muc.de>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Debian Thunderbird 1.0 (X11/20050116)
Andi Kleen wrote:
Baruch Even <baruch@xxxxxxxxx> writes:

I can squeeze the tcp_skb_cb to one pointer at the expense of extra
work to remove a packet from the list (the other pointer is the prev
pointer).

You could also use a xor list in theory. But I'm not sure it's worth it. Increasing cb by 4 bytes shouldn't be a very big issue.

If increasing the cb by 4 bytes is ok, it would make my life easier and the code simpler. But I don't think it would also be a big issue to remove the prev pointer.


Now, if we can agree on increasing the tcp_sock by 20 bytes I'll be able to continue my work.

Baruch

<Prev in Thread] Current Thread [Next in Thread>