Re: [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]

[Ben Greear <greearb@xxxxxxxxxxxxxxx>]

Stephen Hemminger wrote:
> On Sat, 5 Mar 2005 15:12:25 +0100
> Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx> wrote:
>
>
> > ----- Forwarded message from Leo Yuriev <leo@xxxxxxxxx> -----
> >
> > From: Leo Yuriev <leo@xxxxxxxxx>
> > To: Lennert Buytenhek <buytenh@xxxxxxx>,
> >         Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame 
> > has VLAN-header
> >
> > Kernel 2.6 (2.6.11)
> >
> > When ethernet-bridge forward a packet and such ethernet-frame has
> > VLAN-tag, bridge should update skb->prioriry for properly QoS
> > handling.
> >
> > This small patch does this. Currently vlan_TCI-priority directly
> > mapped to skb->priority, but this looks enough.
>
>
> I don't see why the VLAN code doesn't handle this itself. I don't like special
> case layer violations because it becomes a slippery slope with more and
> more additions.

VLAN does handle this.  The main use for the patch is for bridging VLANs
across a normal ethernet device, it appears.  Ie, not really using
the VLAN module at all.

Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com