netdev
[Top] [All Lists]

Re: [PATCH] (1/12) skge: use PFX string

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] (1/12) skge: use PFX string
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Thu, 03 Mar 2005 16:37:34 -0500
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050303114557.6373662b@dxpl.pdx.osdl.net>
References: <20050303114557.6373662b@dxpl.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Applied patches 1-12, but comments follow.

Also, a procedural comment:

Please place the "1/12" number _inside_ square brackets, like so:

        [PATCH 1/12] skge: use PFX string

Reason: Everything inside the brackets is converted to the constant string "[PATCH]". With your submission, I had to hand-edit 12 comments, removing the "x/12" from each one.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>