Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo

[Jeff Garzik <jgarzik@xxxxxxxxx>]

David S. Miller wrote:
> On Thu, 03 Mar 2005 14:46:32 -0600
> Matt Mackall <mpm@xxxxxxxxxxx> wrote:
>
>
> > Packets that have destructors should not be zapped here as that might
> > produce additional printk warnings via netconsole.
> >
> > Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>
>
>
> Then where will they be freed, eh? :-)
>
> This patch adds an SKB leak.  Since you've NULL'd out the list, any
> SKB skipped will never be freed up at all.

Heh, I was just writing this same message.

On a related note...  David, I would prefer if you merged up the netpoll 
stuff, since it touches mainly net/*

Is that cool w/ you?

        Jeff