Re: [PATCH]: r8169: Expose hardware stats via ethtool

[Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>]

Hello.

Thanks for reviewing, Francois, Jon & Jeff!

Francois Romieu wrote:
[snip]
> Btw I'd simply remove the 'work' variable and schedule in an interruptible
> way until the dump is done.

OK, that will take me a bit longer to code. ;)

> BUG() is a bit exagerated imho.

It seems like a pretty good way of avoiding a buffer overrun to me. 
E.g.: you copy an extra statistic in rtl8169_get_ethtool_stats(), but 
forget to update the stats length. Is it not better to crash early, than 
encounter random behaviour later?

I can put an #ifdef RTL8169_DEBUG / #endif around it, if you'd be happier.

Thanks, bye, Rich =]

--
Richard Dawe [ http://homepages.nildram.co.uk/~phekda/richdawe/ ]

"You can't evaluate a man by logic alone."
  -- McCoy, "I, Mudd", Star Trek