Re: [PATCH] pktgen: reduce stack usage

["Randy.Dunlap" <rddunlap@xxxxxxxx>]

Ben Greear wrote:
> Randy.Dunlap wrote:
>
> > (resend)
> > Any comments this time?
> >
> > pktgen: proc_if_write: reduce stack usage (on i386)
> > from 776 to 296 bytes by combining/reusing locals.
>
> Since these methods are not in the fast path, and the stack
> usage is not near 4k, does this really matter?

It's not critical or near causing a stack overflow AFAICT.
And ideally gcc would recognize this kind of usage and not
allocate multiple stack entries for it.


syscall:    sys_write (tiny stack usage)
                -> vfs_write (tiny)
                   -> proc_file_write (tiny)
                      -> proc_if_write (pktgen: large)

> I'm asking more to be educated than to dismiss the changes....

--
~Randy