netdev
[Top] [All Lists]

Re: [PATCH] pktgen: reduce stack usage

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [PATCH] pktgen: reduce stack usage
From: "Randy.Dunlap" <rddunlap@xxxxxxxx>
Date: Fri, 18 Feb 2005 14:20:40 -0800
Cc: robert.olsson@xxxxxxxxx, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20050218221121.GA22845@electric-eye.fr.zoreil.com>
Organization: OSDL
References: <20050218134219.3f079110.rddunlap@osdl.org> <20050218221121.GA22845@electric-eye.fr.zoreil.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0 (X11/20041206)
Francois Romieu wrote:
Randy.Dunlap <rddunlap@xxxxxxxx> :

(resend)
Any comments this time?


Did I miss a simultaneous use of both buffers or could it be possible to
save an extra IP_NAME_SZ bytes of data with an evil ugly union ?

That's probably doable, I'll double-check it and modify the patch...

Btw, does anyone intend to fix the use of sleepable functions in proc_thread_write() with spinlock ("thread_lock") held or should
I allocate it some cycles ?

-- ~Randy

<Prev in Thread] Current Thread [Next in Thread>