| To: | netdev@xxxxxxxxxxx |
|---|---|
| Subject: | [patch] superfluous CAP_NET_ADMIN required for some ioctl |
| From: | Laurent Deniel <laurent.deniel@xxxxxxx> |
| Date: | Tue, 01 Feb 2005 21:49:14 +0100 |
| Organization: | Home |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020 |
It should be possible to obtain bonding information with SIOCBOND[SLAVE]INFOQUERY ioctls without root privilege (like with /proc/net/bonding/bond? or ifconfig). Laurent Signed-off-by: Laurent Deniel <laurent.deniel@xxxxxxx> --- linux-2.6.9.orig/net/core/dev.c 2005-01-08 17:29:55.000000000 +0100
+++ linux-2.6.9/net/core/dev.c 2005-01-08 18:00:01.000000000 +0100
@@ -2692,8 +2692,6 @@ int dev_ioctl(unsigned int cmd, void __u
case SIOCBONDENSLAVE:
case SIOCBONDRELEASE:
case SIOCBONDSETHWADDR:
- case SIOCBONDSLAVEINFOQUERY:
- case SIOCBONDINFOQUERY:
case SIOCBONDCHANGEACTIVE:
case SIOCBRADDIF:
case SIOCBRDELIF:
@@ -2705,6 +2703,20 @@ int dev_ioctl(unsigned int cmd, void __u
rtnl_unlock();
return ret;+ /*
+ * These ioctl calls:
+ * - can be done by all.
+ * - require strict serialization.
+ * - return a value (but already copied to user)
+ */
+ case SIOCBONDSLAVEINFOQUERY:
+ case SIOCBONDINFOQUERY:
+ dev_load(ifr.ifr_name);
+ rtnl_lock();
+ ret = dev_ifsioc(&ifr, cmd);
+ rtnl_unlock();
+ return ret;
+
case SIOCGIFMEM:
/* Get the per device memory space. We can add this but
* currently do not support it */ |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [ PATCH ] 2.6 eepro100: replace and delete duplicate ids, Xose Vazquez Perez |
|---|---|
| Next by Date: | [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV, Dan Williams |
| Previous by Thread: | [ PATCH ] 2.6 eepro100: replace and delete duplicate ids, Xose Vazquez Perez |
| Next by Thread: | [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV, Dan Williams |
| Indexes: | [Date] [Thread] [Top] [All Lists] |