netdev
[Top] [All Lists]

Re: patch: tc action cleanups

To: hadi@xxxxxxxxxx
Subject: Re: patch: tc action cleanups
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sun, 16 Jan 2005 19:29:42 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1105899636.1090.794.camel@jzny.localdomain>
References: <1105899636.1090.794.camel@jzny.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041008 Debian/1.7.3-5
jamal wrote:

Heres one i think you didnt resurect Patrick. If ok, Dave please apply.
Other than that i cant seem to find anything at issue with the core
(havent looked at the individual actions other than to follow changed
code from the core).

bindcnt/refcnt changes are protected by the rtnl, no need for extra locking.
The lock only needs to protect data shared with the "act" function.

Very well done.

A couple additional fixes are coming up later tonight.

Regards
Patrick


<Prev in Thread] Current Thread [Next in Thread>