netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c

from [Tommy Christensen] [Permanent Link][Original]
To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c
From: Tommy Christensen <tommy.christensen@xxxxxxxxx>
Date: Sun, 16 Jan 2005 09:34:59 +0100
Cc: simon.roscic@xxxxxxxxx, netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
In-reply-to: <20050116080254.GA2997@gondor.apana.org.au>
References: <E1Cpo1q-0007lI-00@gondolin.me.apana.org.au> <41E942AF.3030202@tpack.net> <20050115183023.GA31211@gondor.apana.org.au> <41E97B1A.30205@tpack.net> <20050116080254.GA2997@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803
Herbert Xu wrote: 
I'm hesitant to put an outright ban on it since it will force callers
such as kernel/audit.c to always do an skb_clone.

So here is a patch to handle shared skb's by cloning them if we're
going to do a pskb_expand_head.  This patch depends on the previous
one that moves skb_orphan into netlink_trim.


Very nice, Herbert. This should be fine for everybody.

-Tommy

[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c, Herbert Xu
Next by Date:  [PATCH] ipv6: alternative version of S/390 shared NIC support, Christoph Hellwig
Previous by Thread:  [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c, Herbert Xu
Next by Thread:  Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c, David S. Miller
Indexes:  [Date] [Thread] [Top] [All Lists]