netdev
[Top] [All Lists]

Re: request_module while holding rtnl semaphore

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: request_module while holding rtnl semaphore
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Tue, 11 Jan 2005 22:05:07 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050111094752.GD26856@postel.suug.ch>
References: <41899DCF.3050804@trash.net> <E1CQDcP-0003ff-00@gondolin.me.apana.org.au> <20041109161126.376f755c.davem@davemloft.net> <41E34252.504@trash.net> <20050111094752.GD26856@postel.suug.ch>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041008 Debian/1.7.3-5
Thomas Graf wrote:

* Patrick McHardy <41E34252.504@xxxxxxxxx> 2005-01-11 04:04

This patch got lost somehow. The act_api.c changes are actually
even more complicated because besides the action init path, changes
can also be made from classifiers in a deep call-chain. I hope
Thomas's recent changes make it easier to fix this, but I think
this patch should go in now anyway.


The action initialization is now done first and no classifier data is changed except for tp->root modifications which must not be undone so you can safely return EBUSY. rsvp might be an exception, I haven't looked too closely into it yet.

tcindex returns EBUSY when a filter is changed which does not fit
into the hashtable, so this must be changed.

It's -EAGAIN, so no problem, nothing returns this currently. I'm going to
send a patch later.

Regards
Patrick


<Prev in Thread] Current Thread [Next in Thread>