netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH PKT_SCHED 11/17]: Remove checks for impossible conditions in

from [Patrick McHardy] [Permanent Link][Original]
To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH PKT_SCHED 11/17]: Remove checks for impossible conditions in ipt action
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Thu, 30 Dec 2004 15:25:13 +0100
Cc: jamal <hadi@xxxxxxxxxx>, Maillist netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20041230134029.GX32419@postel.suug.ch>
References: <41D378AB.70204@trash.net> <20041230134029.GX32419@postel.suug.ch>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
Thomas Graf wrote: 
* Patrick McHardy <41D378AB.70204@xxxxxxxxx> 2004-12-30 04:40

-       if (a == NULL || rta == NULL ||
-           rtattr_parse(tb, TCA_IPT_MAX, RTA_DATA(rta), RTA_PAYLOAD(rta)) < 0)
+       if (rtattr_parse(tb, TCA_IPT_MAX, RTA_DATA(rta), RTA_PAYLOAD(rta)) < 0)
                return -1;



You might want to use rtattr_parse_nested here (see patch 1 of my latest
patchset)

if (rtattr_parse_nested(tb, TCA_IPT_MAX, rta) < 0)

Purely cosmetic though. It gives a slightly better hint on what is being
done.


We can do this once your changes are merged (I'll review
them later today). For now I prefer to leave it this way
so I can work on a vanilla tree.

Regards
Patrick

[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH PKT_SCHED 4/17]: Check TCA_ACT_KIND payload size _before_ copying it, Patrick McHardy
Next by Date:  ing_filter debug messages, Wichert Akkerman
Previous by Thread:  Re: [PATCH PKT_SCHED 11/17]: Remove checks for impossible conditions in ipt action, Thomas Graf
Next by Thread:  [PATCH PKT_SCHED 12/17]: Fix missing unlock in ipt action error path, Patrick McHardy
Indexes:  [Date] [Thread] [Top] [All Lists]