Re: Lockup with 2.6.9-ac15 related to netconsole

[Patrick McHardy <kaber@xxxxxxxxx>]

Francois Romieu wrote:
> Marc, if the patch below happens to work, it should not drop messages
> like the previous one (it is an ugly short-term suggestion).

> -       spin_lock(&np->dev->xmit_lock);
> +       while (!spin_trylock(&np->dev->xmit_lock)) {
> +               if (np->dev->xmit_lock_owner == smp_processor_id()) {
> +                       struct Qdisc *q = dev->qdisc;
> +
> +                       q->ops->enqueue(skb, q);

Shouldn't this be requeue ?

Regards
Patrick