netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [patch 1/4] net/ne2k-pci: module_param conversion

from [Jeff Garzik] [Permanent Link][Original]
To: janitor@xxxxxxxxxxxxxx
Subject: Re: [patch 1/4] net/ne2k-pci: module_param conversion
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 24 Nov 2004 15:05:09 -0500
Cc: netdev@xxxxxxxxxxx, domen@xxxxxxxxxxxx
In-reply-to: <E1CVLFE-0002CL-PU@sputnik>
References: <E1CVLFE-0002CL-PU@sputnik>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
janitor@xxxxxxxxxxxxxx wrote:
@@ -443,8 +435,7 @@ static void ne2k_pci_reset_8390(struct n
{
unsigned long reset_start_time = jiffies;
- if (debug > 1) printk("%s: Resetting the 8390 t=%ld...",
- dev->name, jiffies);
+ printk(KERN_INFO "%s: Resetting the 8390 t=%ld...", dev->name, jiffies); 


The rest of the patch looks OK.

This chunk changes behavior, by removing the 'if' test.

        Jeff



[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: Acer Aspire 1524WLMi and RealTek 8169 - very slow, Richard Dawe
Next by Date:  Re: net/ne2k-pci: module_param conversion, Domen Puncer
Previous by Thread:  [patch 1/4] net/ne2k-pci: module_param conversion, janitor
Next by Thread:  Re: net/ne2k-pci: module_param conversion, Domen Puncer
Indexes:  [Date] [Thread] [Top] [All Lists]