netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 2.6]: Fix device leaks in mirred action

from [Patrick McHardy] [Permanent Link][Original]
To: hadi@xxxxxxxxxx
Subject: Re: [PATCH 2.6]: Fix device leaks in mirred action
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Thu, 04 Nov 2004 15:58:39 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1099576439.1038.147.camel@jzny.localdomain>
References: <4189CC6A.9040007@trash.net> <1099576439.1038.147.camel@jzny.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041008 Debian/1.7.3-5 
jamal wrote:

It also leaks a reference when a mirred action
is replaced.



How? Is this patch supposed to fix that?


+                       if (ovr)
+                               dev_put(p->dev);
                       p->dev = dev;

By dropping the reference before replacing it.

Regards
Patrick


[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: BUG: dst underflow (again), jamal
Next by Date:  Re: [PATCH 2.6]: Fix device leaks in mirred action, jamal
Previous by Thread:  Re: [PATCH 2.6]: Fix device leaks in mirred action, jamal
Next by Thread:  Re: [PATCH 2.6]: Fix device leaks in mirred action, jamal
Indexes:  [Date] [Thread] [Top] [All Lists]