Re: [patch 05/18] net/s2io: replace schedule

netdev

Re: [patch 05/18] net/s2io: replace schedule_timeout() with msleep()

To:	janitor@xxxxxxxxxxxxxx
Subject:	Re: [patch 05/18] net/s2io: replace schedule_timeout() with msleep()
From:	Jeff Garzik <jgarzik@xxxxxxxxx>
Date:	Sun, 31 Oct 2004 06:09:34 -0500
Cc:	netdev@xxxxxxxxxxx, nacc@xxxxxxxxxx
In-reply-to:	<E1CO1vc-00022t-N2@sputnik>
References:	<E1CO1vc-00022t-N2@sputnik>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

janitor@xxxxxxxxxxxxxx wrote:

@@ -2846,11 +2838,10 @@ static int s2io_ethtool_idnic(struct net
                sp->id_timer.data = (unsigned long) sp;
        }
        mod_timer(&sp->id_timer, jiffies);
-       set_current_state(TASK_INTERRUPTIBLE);
        if (data)
-               schedule_timeout(data * HZ);
+               msleep_interruptible(data * 1000);

clearly wants ssleep() here

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 05/18] net/s2io: replace schedule_timeout() with msleep(), janitor Re: [patch 05/18] net/s2io: replace schedule_timeout() with msleep(), Jeff Garzik <=

Previous by Date:	Re: [patch 06/18] net/cosa: replace schedule_timeout() with msleep_interruptible(), Jeff Garzik
Next by Date:	[PATCH] 8139too: use iomap for pio/mmio, Pekka Enberg
Previous by Thread:	[patch 05/18] net/s2io: replace schedule_timeout() with msleep(), janitor
Next by Thread:	[patch 06/18] net/cosa: replace schedule_timeout() with msleep_interruptible(), janitor
Indexes:	[Date] [Thread] [Top] [All Lists]