Re: [patch 10/18] net/g96100eth: replace gt96100_delay() with msleep

netdev

Re: [patch 10/18] net/g96100eth: replace gt96100_delay() with msleep_i

To:	janitor@xxxxxxxxxxxxxx
Subject:	Re: [patch 10/18] net/g96100eth: replace gt96100_delay() with msleep_interruptible()
From:	Jeff Garzik <jgarzik@xxxxxxxxx>
Date:	Sun, 31 Oct 2004 06:06:23 -0500
Cc:	netdev@xxxxxxxxxxx, nacc@xxxxxxxxxx
In-reply-to:	<E1CO1vu-0002Lf-5c@sputnik>
References:	<E1CO1vu-0002Lf-5c@sputnik>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

janitor@xxxxxxxxxxxxxx wrote:

@@ -528,7 +517,7 @@ abort(struct net_device *dev, u32 abort_
        // wait for abort to complete
        while (GT96100ETH_READ(gp, GT96100_ETH_SDMA_COMM) & abort_bits) {
                // snooze for 20 msec and check again
-               gt96100_delay(1);
+               msleep_interruptible(20);
        
                if (--timedout == 0) {

don't change the behavior of the driver, even if it disagrees with the comment.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 10/18] net/g96100eth: replace gt96100_delay() with msleep_interruptible(), janitor Re: [patch 10/18] net/g96100eth: replace gt96100_delay() with msleep_interruptible(), Jeff Garzik <=

Previous by Date:	Re: [patch 11/18] net/pcnet32: replace schedule_timeout() with msleep_interruptible(), Jeff Garzik
Next by Date:	Re: [patch 06/18] net/cosa: replace schedule_timeout() with msleep_interruptible(), Jeff Garzik
Previous by Thread:	[patch 10/18] net/g96100eth: replace gt96100_delay() with msleep_interruptible(), janitor
Next by Thread:	[patch 11/18] net/pcnet32: replace schedule_timeout() with msleep_interruptible(), janitor
Indexes:	[Date] [Thread] [Top] [All Lists]